Add Norwegian locale for number formatters

radoondas created this issue on 2020-01-09 · The issue is replied 9 times

Describe the feature:
I would like to add Norwegian locale support in to Kinana number formatters.
At the moment, Kibana fork of numeral.js does not have no locale: (https://github.com/elastic/numeral-js/tree/kibana-fork/languages)

However, official master has the implementation available: https://github.com/adamwdraper/Numeral-js/tree/master/locales

Describe a specific use case for the feature:
More users will be happy with correct selection for their language.

elasticmachine wrote this answer on 2020-01-09

Pinging @elastic/kibana-platform (Team:Platform)

timroes wrote this answer on 2020-01-10

Will be solved via #53972

elasticmachine wrote this answer on 2020-01-10

Pinging @elastic/kibana-app-arch (Team:AppArch)

wylieconlon wrote this answer on 2020-01-10

Yes, my change will help, but we should also update our fork.

radoondas wrote this answer on 2020-02-03

Closure Summary

Recap

  • Missing Norwegian locale in Kibana formatting options
  • We are using old implementation of the library which provides locale
  • Will be fixed in new version of Kibana (7.7?) where we will implement different approach for the formatting. See linked issues.

Cause

  • old JS library for formatting

Takeaways

  • Shouldl be fixed in v7.7?
wylieconlon wrote this answer on 2020-02-03

I think this has been closed prematurely- the PR I have worked on will definitely not be in 7.7

radoondas wrote this answer on 2020-02-03

My apologies. Incorrect repository.

pettertho wrote this answer on 2020-02-03

Is it an option to update the NumeralJs fork in Kibana with additional localizations, so the issue is mitigated? Or is that a big task?

wylieconlon wrote this answer on 2020-02-03

I don't expect that it's a large task, but I am not qualified to provide logic for Norwegian. Feel free to submit a pull request: https://github.com/elastic/numeral-js/tree/kibana-fork/languages

More Details About Repo
Owner Name elastic
Repo Name kibana
Full Name elastic/kibana
Language TypeScript
Created Date 2013-01-26
Updated Date 2021-11-25
Star Count 16751
Watcher Count 841
Fork Count 6946
Issue Count 9237

YOU MAY BE INTERESTED

Issue Title State Comments Created Date Updated Date Closed Date
Support for [FromServices] attribute? closed 1 2021-05-01 2021-11-17 2021-05-02
Problem: Indexing 0 titles (at `rebuild_index` command) open 0 2021-03-08 2021-11-23 -
Cloudwatch measurement interval set to 5 minutes lead to wrong calculations closed 7 2021-07-05 2021-11-21 2021-09-27
Issue with “Content is Unreadable. Open and Repair” closed 6 2019-01-12 2021-11-24 2019-01-14
Text in not highlighted when copying in iOS closed 1 2021-09-24 2021-11-22 2021-09-24
[BUG] url_redirector not working in 3.0 open 7 2021-08-30 2021-11-03 -
Today is not earth day open 1 2021-11-15 2021-11-23 -
TextEdit control should contain scrole bars open 0 2021-08-25 2021-11-09 -
Show DNS name in addition to the client name in query log open 0 2021-10-10 2021-11-14 -
Proposal: Make codebase format more relational open 1 2021-10-25 2021-11-11 -